Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor with integration into match_redundant_around_hook_block #1621

Merged
merged 1 commit into from
Apr 18, 2023

Conversation

ydah
Copy link
Member

@ydah ydah commented Apr 18, 2023

Follow up: #1620 (review)


Before submitting the PR make sure the following are checked:

  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • [-] Added tests.
  • [-] Updated documentation.
  • [-] Added an entry to the CHANGELOG.md if the new code introduces user-observable changes.
  • The build (bundle exec rake) passes (be sure to run this locally, since it may produce updated documentation that you will need to commit).

Copy link
Member

@pirj pirj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!
I think the original intention behind (args _?) was to make sure |example| is present as a block argument. But the whole hook wouldn't make sense without it anyway.

@pirj pirj requested review from bquorning and Darhazer April 18, 2023 06:37
Copy link
Collaborator

@bquorning bquorning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we put this into the v2.20.0 release as well?

@ydah
Copy link
Member Author

ydah commented Apr 18, 2023

@bquorning Please include, if possible 😀

@pirj pirj merged commit 7e2a570 into rubocop:master Apr 18, 2023
23 checks passed
@ydah ydah deleted the refactor-RedundantAround branch April 18, 2023 06:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants