Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump version to v2.20.0 #1600

Merged
merged 1 commit into from
Apr 18, 2023
Merged

Bump version to v2.20.0 #1600

merged 1 commit into from
Apr 18, 2023

Conversation

bquorning
Copy link
Collaborator

@bquorning bquorning commented Mar 13, 2023

Should we push a bugfix minor release?


Before submitting the PR make sure the following are checked:

  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Updated documentation.
  • Added an entry to the CHANGELOG.md if the new code introduces user-observable changes.
  • The build (bundle exec rake) passes (be sure to run this locally, since it may produce updated documentation that you will need to commit).

@bquorning bquorning marked this pull request as ready for review March 13, 2023 20:05
@pirj
Copy link
Member

pirj commented Mar 13, 2023

I apologize for the late appearance, I have some doubts regarding this change.

@ydah
Copy link
Member

ydah commented Mar 16, 2023

@bquorning @pirj Sorry for the delay in responding. I have opened a revised proposal on the matter as a PR. Please give me your feedback.

@bquorning bquorning marked this pull request as draft March 16, 2023 16:54
@bquorning
Copy link
Collaborator Author

@pirj Does #1604 address your concerns?

@ydah
Copy link
Member

ydah commented Mar 25, 2023

@pirj @bquorning @Darhazer #1603 Sorry to bother you, but we would like to decide on a response plan and include it in the release.

@ydah
Copy link
Member

ydah commented Apr 14, 2023

@bquorning @pirj
I believe this has probably resolved the blockers for the release. Please let me know if I have missed anything.
The following PR is closed.

@pirj
Copy link
Member

pirj commented Apr 14, 2023

No objections to releasing what we have.

@bquorning bquorning changed the title Bump version to v2.19.1 Bump version to v2.20.0 Apr 17, 2023
@bquorning
Copy link
Collaborator Author

I have updated this PR to now cut a minor release (v2.20.0). Are there any more pull requests we should merge for this release?

@bquorning bquorning marked this pull request as ready for review April 17, 2023 06:23
@ydah
Copy link
Member

ydah commented Apr 17, 2023

I think the following PR looks good to merge for this release.

@ydah
Copy link
Member

ydah commented Apr 17, 2023

@bquorning @pirj @Darhazer
BTW, I would like to extract the RuboCop FactoryBot for the v2.21.0 release. WDYT?

@bquorning
Copy link
Collaborator Author

cc @rubocop/rubocop-rspec

@pirj
Copy link
Member

pirj commented Apr 17, 2023

#1610 and #1574 look solid.
#1527 is fine too, just needs a rebase. I never got to rubocop-rspec-rails extraction, so it doesn't make sense to keep holding it off.

@pirj
Copy link
Member

pirj commented Apr 17, 2023

All for the FactoryBot extraction in 2.21.0 🙌

@ydah
Copy link
Member

ydah commented Apr 18, 2023

The test that is now failing in CI / Edge RuboCop: spec will also succeed with #1620

@pirj
Copy link
Member

pirj commented Apr 18, 2023

#1619 is a small one, now green thanks to #1620.

@bquorning
Copy link
Collaborator Author

Thanks for the feedback, I have updated this PR after merging the suggested PRs:

I also tried reordering the changelog entry for this release, to closer resemble what is recommended by https://keepachangelog.com/en/1.0.0/ (“The same types of changes should be grouped” they say, and list “Types of changes” as Added, Changed, Deprecated, Removed, Fixed, Security)

Copy link
Member

@pirj pirj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! 🙌
🚢

This time I tried reordering the changelog (like they do on keepachangelog.com)
with "Added" features first, then "Fixed", followed by "Changed".
@bquorning bquorning merged commit 454ec6d into master Apr 18, 2023
23 checks passed
@bquorning bquorning deleted the release branch April 18, 2023 06:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants