-
-
Notifications
You must be signed in to change notification settings - Fork 269
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump version to v2.20.0 #1600
Bump version to v2.20.0 #1600
Conversation
I apologize for the late appearance, I have some doubts regarding this change. |
@bquorning @pirj Sorry for the delay in responding. I have opened a revised proposal on the matter as a PR. Please give me your feedback. |
@pirj @bquorning @Darhazer #1603 Sorry to bother you, but we would like to decide on a response plan and include it in the release. |
@bquorning @pirj |
No objections to releasing what we have. |
I have updated this PR to now cut a minor release (v2.20.0). Are there any more pull requests we should merge for this release? |
I think the following PR looks good to merge for this release. |
@bquorning @pirj @Darhazer |
cc @rubocop/rubocop-rspec |
All for the FactoryBot extraction in 2.21.0 🙌 |
The test that is now failing in CI / Edge RuboCop: spec will also succeed with #1620 |
Thanks for the feedback, I have updated this PR after merging the suggested PRs:
I also tried reordering the changelog entry for this release, to closer resemble what is recommended by https://keepachangelog.com/en/1.0.0/ (“The same types of changes should be grouped” they say, and list “Types of changes” as Added, Changed, Deprecated, Removed, Fixed, Security) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! 🙌
🚢
This time I tried reordering the changelog (like they do on keepachangelog.com) with "Added" features first, then "Fixed", followed by "Changed".
Should we push a
bugfixminor release?Before submitting the PR make sure the following are checked:
master
(if not - rebase it).CHANGELOG.md
if the new code introduces user-observable changes.bundle exec rake
) passes (be sure to run this locally, since it may produce updated documentation that you will need to commit).