Add support be_status style for RSpec/Rails/HttpStatus
#1527
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ydah
force-pushed
the
feature/1148
branch
4 times, most recently
from
94e5ddc
to
684e42b
Compare
ydah
force-pushed
the
feature/1148
branch
2 times, most recently
from
d05c7cb
to
2c5a1c0
Compare
|
I'd hold this off until |
pirj
reviewed
Jan 24, 2023
| @@ -41,12 +54,13 @@ class HttpStatus < Base | |||
| PATTERN | |||
|
|
|||
| def on_send(node) | |||
There was a problem hiding this comment.
It seems this cop has a bias towards the new style, as it inspects have_http_status calls, but doesn't care if be_* are used when configured to use numeric or symbolic styles.
It's not a big problem, since otherwise it would detect false positives in e.g. non-controller/request specs.
Maybe it makes sense to reflect this in our docs somehow.
|
|
|
@pirj Sorry for the late reply. And thanks for checking usage stats for various styles in |
ydah
commented
Jan 24, 2023
Comment on lines
11
to
13
| # This cop inspects only `have_http_status` calls. | ||
| # So, this cop do not check if a method starting with `be_*` is used | ||
| # when setting for `EnforcedStyle: symbolic` or `EnforcedStyle: numeric`. |
There was a problem hiding this comment.
ydah
force-pushed
the
feature/1148
branch
2 times, most recently
from
9c9711a
to
baad961
Compare
Closed
bquorning
approved these changes
Apr 18, 2023
ydah
force-pushed
the
feature/1148
branch
2 times, most recently
from
6315e13
to
fb347a3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: #1148
Before submitting the PR make sure the following are checked:
master(if not - rebase it).CHANGELOG.mdif the new code introduces user-observable changes.bundle exec rake) passes (be sure to run this locally, since it may produce updated documentation that you will need to commit).If you have modified an existing cop's configuration options:
VersionChanged: "<<next>>"inconfig/default.yml.