Rails/DuplicateAssociation: False positive for belongs_to

[franzliedke]

Introduced by PR #1145.

The documented "bad" belongs_to example is a false positive.

The following example should make this clear:

class GraphEdge
  belongs_to :source_node, class_name: "GraphNode"
  belongs_to :target_node, class_name: "GraphNode"
end

Contrary to has_many, the names of belongs_to associations are not arbitrary, as they implicitly reference the foreign key.

Originally posted by @franzliedke in #1145 (comment)

[twohlix]

This is a common use case in one of my codebases (and new false positive for the cop) where you have two or three users joined in context specific ways for a transaction. e.g.

  belongs_to :attendant, class_name: 'User'
  belongs_to :collector, class_name: 'User'

I'm in agreement that in my codebase its all belongs_to relationships.

[gsar]

what's more, the autocorrect happily deletes the second line when asking for --safe-auto-correct. this autocorrect should not be marked safe, i.e. should only work with -A

[koic]

This issue was resolved by #1170 and RuboCop Rails 2.22.1 was released. Thank you for the feedback!