Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bug in the Performance/TimesMap cop #421

Closed
ydakuka opened this issue Dec 10, 2023 · 0 comments · Fixed by #423
Closed

Fix bug in the Performance/TimesMap cop #421

ydakuka opened this issue Dec 10, 2023 · 0 comments · Fixed by #423

Comments

@ydakuka
Copy link
Contributor

ydakuka commented Dec 10, 2023

Follow by #420
koic added a commit to koic/rubocop-performance that referenced this issue Dec 12, 2023
@koic
[Fix rubocop#421] Fix false positives for Performance/TimesMap
52c999a 
Fixes rubocop#421.

This PR fixes false positives for `Performance/TimesMap`
with a block with safe navigation call for nil literal.

It does not have a changelog entry because it is a patch to
a feature that has not been released yet.
@koic koic mentioned this issue Dec 12, 2023
Merged
8 tasks
koic added a commit to koic/rubocop-performance that referenced this issue Dec 13, 2023
@koic
[Fix rubocop#421] Fix false positives for Performance/TimesMap
68632dd 
Fixes rubocop#421.

This PR fixes false positives for `Performance/TimesMap`
with a block with safe navigation call for nil literal.

It does not have a changelog entry because it is a patch to
a feature that has not been released yet.
@koic koic closed this as completed in #423 Dec 14, 2023
koic added a commit that referenced this issue Dec 14, 2023
@koic
Merge pull request #423 from koic/fix_false_positives_for_performance…
416e05c 
…_times_map

[Fix #421] Fix false positives for `Performance/TimesMap`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Fix #421] Fix false positives for Performance/TimesMap koic/rubocop-performance
1 participant
@ydakuka