Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New cop suggestion: detect focussed tests #301

Closed
gravitystorm opened this issue Feb 7, 2024 · 0 comments
Closed

New cop suggestion: detect focussed tests #301

gravitystorm opened this issue Feb 7, 2024 · 0 comments
Labels
feature request Request for new functionality

Comments

@gravitystorm
Copy link

Is your feature request related to a problem? Please describe.

minitest-focus is a great utility to focus in on one test at a time. But the risk is that someone accidentally leaves a test focussed while committing, and nobody notices the test suite is now only one test long.

Describe the solution you'd like

I'd like to see a test that catches this, and fails if any focussed tests are found.

Additional context

rubocop-rspec has the equivalent cop to this - see https://docs.rubocop.org/rubocop-rspec/cops_rspec.html#rspecfocus

jaredmoody added a commit to Jetbuilt/rubocop-minitest that referenced this issue Feb 14, 2024
jaredmoody added a commit to Jetbuilt/rubocop-minitest that referenced this issue Feb 14, 2024
jaredmoody added a commit to Jetbuilt/rubocop-minitest that referenced this issue Feb 16, 2024
jaredmoody added a commit to Jetbuilt/rubocop-minitest that referenced this issue Feb 16, 2024
jaredmoody added a commit to Jetbuilt/rubocop-minitest that referenced this issue Feb 16, 2024
@koic koic added the feature request Request for new functionality label Feb 16, 2024
jaredmoody added a commit to Jetbuilt/rubocop-minitest that referenced this issue Feb 16, 2024
@koic koic closed this as completed in a584c01 Feb 17, 2024
koic added a commit that referenced this issue Feb 17, 2024
[Fix #301] Add new Minitest/Focus cop
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request Request for new functionality
Projects
None yet
Development

No branches or pull requests

2 participants