Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: rubocop/rubocop-minitest
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v0.35.0
Choose a base ref
...
head repository: rubocop/rubocop-minitest
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v0.35.1
Choose a head ref
  • 12 commits
  • 10 files changed
  • 2 contributors

Commits on Mar 10, 2024

  1. Switch back docs version to master

    koic committed Mar 10, 2024

    Verified

    This commit was signed with the committer’s verified signature.
    ljharb Jordan Harband
    Copy the full SHA
    c0357e6 View commit details

Commits on Mar 12, 2024

  1. Make AssertOffense support assert_no_corrections

    Despite being mentioned in the `AssertOffense` documentation, `assert_no_corrections` was not supported:
    https://github.com/rubocop/rubocop-minitest/blob/v0.35.0/lib/rubocop/minitest/assert_offense.rb#L58-L72
    
    This PR makes `assert_no_corrections` supported in accordance with the documentation.
    koic committed Mar 12, 2024

    Verified

    This commit was signed with the committer’s verified signature.
    ljharb Jordan Harband
    Copy the full SHA
    4494792 View commit details

Commits on Mar 16, 2024

  1. Merge pull request #307 from koic/support_no_corrections

    Make `AssertOffense` support `assert_no_corrections`
    koic authored Mar 16, 2024

    Verified

    This commit was signed with the committer’s verified signature.
    ljharb Jordan Harband
    Copy the full SHA
    50e8859 View commit details

Commits on May 29, 2024

  1. Fix readme CI badge

    Earlopain committed May 29, 2024

    Verified

    This commit was signed with the committer’s verified signature.
    ljharb Jordan Harband
    Copy the full SHA
    e318bfe View commit details
  2. Merge pull request #309 from Earlopain/readme-badge

    Fix readme CI badge
    koic authored May 29, 2024

    Verified

    This commit was signed with the committer’s verified signature.
    ljharb Jordan Harband
    Copy the full SHA
    0b8c8a2 View commit details

Commits on Jun 15, 2024

  1. Use sh instead of system cmd, exception: true in *.rake

    koic committed Jun 15, 2024
    Copy the full SHA
    654e0e6 View commit details

Commits on Jul 1, 2024

  1. Use RuboCop Performance 1.21

    This commit disables `Performance/StringIdentifierArgument` under the `test/**` directory
    to suppress the following detection:
    
    ```console
    test/rubocop/cop/minitest/assert_match_test.rb:7:19: C: [Correctable] Performance/StringIdentifierArgument:
    Use :"test_registers_offense_when_using_assert_with_#{matcher}" instead of "test_registers_offense_when_using_assert_with_#{matcher}".
        define_method("test_registers_offense_when_using_assert_with_#{matcher}") do
                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    ```
    
    This setting is because the code in this directory is test code, and performance is not of utmost importance.
    Additionally, `:"Use ..."` is not necessarily more readable than `"Use ..."`.
    koic committed Jul 1, 2024
    Copy the full SHA
    97ddbb1 View commit details

Commits on Jul 6, 2024

  1. Suppress RuboCop offenses

    This commit suppresses the following new RuboCop offenses:
    
    ```console
    $ bundle exec rubocop
    (snip)
    
    rubocop-minitest.gemspec:35:8: C: [Correctable] Gemspec/AddRuntimeDependency:
    Use add_dependency instead of add_runtime_dependency.
      spec.add_runtime_dependency 'rubocop', '>= 1.61', '< 2.0'
           ^^^^^^^^^^^^^^^^^^^^^^
    rubocop-minitest.gemspec:36:8: C: [Correctable] Gemspec/AddRuntimeDependency:
    Use add_dependency instead of add_runtime_dependency.
      spec.add_runtime_dependency 'rubocop-ast', '>= 1.31.1', '< 2.0'
           ^^^^^^^^^^^^^^^^^^^^^^
    
    136 files inspected, 2 offenses detected, 2 offenses autocorrectable
    ```
    koic committed Jul 6, 2024
    Copy the full SHA
    9955aa1 View commit details

Commits on Jul 10, 2024

  1. Suppress deprecation warning for Minitst/MultipleAssertions

    Follow up rubocop/rubocop#13032 and
    rubocop/rubocop#9471.
    
    This PR suppresses deprecation warning for `Minitst/MultipleAssertions`.
    koic committed Jul 10, 2024
    Copy the full SHA
    2ad914d View commit details
  2. Merge pull request #311 from koic/suppress_deprecation_warning_for_mi…

    …nitest_multiple_assertions
    
    Suppress deprecation warning for `Minitst/MultipleAssertions`
    koic authored Jul 10, 2024
    Copy the full SHA
    3f9c8a9 View commit details
  3. Update Changelog

    koic committed Jul 10, 2024
    Copy the full SHA
    1a1d11e View commit details
  4. Cut 0.35.1

    koic committed Jul 10, 2024
    Copy the full SHA
    07c4bd5 View commit details
Loading