Support node groups in Node#each_descendant and similar traversal methods
#357
+55
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Earlopain
commented
Jan 21, 2025
| @@ -98,7 +95,7 @@ class Node < Parser::AST::Node # rubocop:disable Metrics/ClassLength | |||
| kwrestarg: :argument, | |||
| blockarg: :argument, | |||
| forward_arg: :argument, | |||
| shardowarg: :argument, | |||
| shadowarg: :argument, | |||
There was a problem hiding this comment.
Typo since this was added, tests caught it when I started using each_descendant(:argument)
koic
reviewed
Jan 22, 2025
lib/rubocop/ast/node.rb
Outdated
| @@ -528,6 +525,14 @@ def range_type? | |||
| GROUP_FOR_TYPE[type] == :range | |||
| end | |||
|
|
|||
| def type_or_group_type?(type) | |||
| type == self.type || GROUP_FOR_TYPE[self.type] == type | |||
| end | |||
There was a problem hiding this comment.
I'm uncertain whether the behavior indicated by the name type_or_group_type? is clear. Since it currently seems to be called only from yield_for_types, how about not publishing type_or_group_type? and making it a private method instead?
There was a problem hiding this comment.
I took another look and seems like I just reimplemented the existing type? method. So, I removed both of these new methods instead.
…ethods Sometimes it would be nice to do `each_child_node(:call)` instead of `each_child_node(:send, :csend)`. This nicely mirrors that you can already use these aliases when writing node patterns
Earlopain
force-pushed
the
visit-X-group-types
branch
from
871144b to
d6908ad
Compare
|
Totally! ❤️ |
Earlopain
added a commit
to Earlopain/rubocop
that referenced
this pull request
Jan 28, 2025
Earlopain
added a commit
to Earlopain/rubocop
that referenced
this pull request
Jan 28, 2025
Earlopain
added a commit
to Earlopain/rubocop
that referenced
this pull request
Jan 28, 2025
8 tasks
Earlopain
added a commit
to Earlopain/rubocop
that referenced
this pull request
Jan 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes it would be nice to do
each_child_node(:call)instead ofeach_child_node(:send, :csend). This nicely mirrors that you can already use these aliases when writing node patterns