Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When selecting candidate keys, protocol and flags are not checked #966

Closed
rthalley opened this issue Jul 25, 2023 · 0 comments
Closed

When selecting candidate keys, protocol and flags are not checked #966

rthalley opened this issue Jul 25, 2023 · 0 comments

Comments

@rthalley
Copy link
Owner

Describe the bug
RFC 4034 requires that a DNSKEY used to verify DNSSEC signatures MUST have protocol 3 and the ZONE flag set. Dnspython currently does not impose these restrictions when validating. Note that this is a standards compliance problem more than a security problem, as a real world DNSSEC validation using such keys could only succeed if the legitimate authority had actually published them since the flags and protocol are included in the DS digest.

Note that It's ok that dnspython can generate such keys and sign with them, so long as it doesn't do this by default, as that is useful for testing.

Context (please complete the following information):

  • dnspython: 2.4.0
  • Python version: any
  • OS: any
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant