-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pin selenium-webdriver to fix a warning #2766
Conversation
Rails 7.1 is unaware of the new API and this crashes our CI
4.19 won’t work on Ruby 2.7
2.7 is broken with a |
Which is confusing, as it seems to load rack/handler/puma, but the Rack::Handler is not loaded. In Puma 5, that file was loading rack/handler and defined Rack::Handler::Puma, but in 6.x this happens only if Rackup is not loaded. |
I’ve merged this as it fixes Ruby 3.x builds with Rails 7.1. |
In both cases, for 2.7 and for 3.x with Rails 7.1, we bundle puma 6.4.2 and also rackup 2.1.0. This means, Rack::Handler::Puma should not be defined. Unless there’s some race condition/load order dependency and we: 1) load rack/handler 2) load puma’s rack/handler/puma 3) (optionally) load rackup. |
The |
What’s interesting is that in another file there's similar code, but it suggests that rack > 3 must be used with rackup gem. |
Pin selenium-webdriver to fix a warning
The problem is capybara fixed this in |
Rails 7.1 is unaware of the new API and this crashes our CI, eg https://github.com/rspec/rspec-rails/actions/runs/9552072568/job/26328604445?pr=2765