HaveHttpStatus uses Rack's public API #2765
Merged
+2
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Unrelated to your PR, but the failures are caused by the lack of this check in 7.1.3.4. I suppose we’d have to pin selenium-webdriver to ~> 4.19.0 here to fix this. |
|
May I kindly ask you to rebase to include the fix and also add a changelog entry? |
Instead of accessing a Constant that isn't a documented part of the Rack API, get the status code for a status name using Rack's supported public API.
darrenboyd
force-pushed
the
rack-public-api-use
branch
from
8d3b0f8 to
b7ab320
Compare
|
Thank you! |
|
2.7/7.1 looks flaky |
JonRowe
added a commit
that referenced
this pull request
Jun 19, 2024
JonRowe
added a commit
that referenced
this pull request
Jun 19, 2024
JonRowe
pushed a commit
that referenced
this pull request
Jun 19, 2024
HaveHttpStatus uses Rack's public API
JonRowe
added a commit
that referenced
this pull request
Jun 19, 2024
JonRowe
added a commit
that referenced
this pull request
Jun 19, 2024
|
Released in 6.1.3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rack has recently changed the name of the 422 status code from
unprocessable_entitytounprocessable_content. SinceHaveHttpStatuswas looking up the code directly through the constant in Rack, this forced developers to rename this value in their codebase in the same change upgrade Rack. Using Rack's public API method (Rack::Utils.status_code) allows users to transition from the old name to the new name on their own schedule.This change fixes #2763