Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: link at mailer preview generator template #2764

Merged
merged 1 commit into from
Jun 17, 2024
Merged

Conversation

chiaraani
Copy link
Contributor

When I execute:

rails g mailer users/confirmations

The link to the preview at the comment is this:

http://localhost:3000/rails/mailers/users/confirmations

This route raises this error:

Unknown action
Mailer preview 'users/confirmations' not found

So I fixed it.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
When I execute:
```
rails g mailer users/confirmations
```
The link to the preview at the comment is this:
```
http://localhost:3000/rails/mailers/users/confirmations
```

This route raises this error:
```
Unknown action
Mailer preview 'users/confirmations' not found
```
So I fixed it.
@pirj
Copy link
Member

pirj commented Jun 14, 2024

Do you think it’s possible to write a failing spec for this?

@JonRowe JonRowe merged commit 35b0a98 into rspec:main Jun 17, 2024
11 of 17 checks passed
@JonRowe
Copy link
Member

JonRowe commented Jun 17, 2024

Thanks, merging despite build failure as its just a template typo

JonRowe added a commit that referenced this pull request Jun 17, 2024
JonRowe added a commit that referenced this pull request Jun 17, 2024
fix: link at mailer preview generator template
JonRowe added a commit that referenced this pull request Jun 17, 2024
@chiaraani
Copy link
Contributor Author

Is it necessary to add a test for a generated code comment?

@JonRowe
Copy link
Member

JonRowe commented Jun 18, 2024

Personally I don't think so, it would be hard to do in a way that wasn't brittle.

@JonRowe
Copy link
Member

JonRowe commented Jun 19, 2024

Released in 6.1.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants