Fix generator for mailer #2735
Merged
Fix generator for mailer #2735
+12
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The build will fail. Once the fix is merged, we’ll kick off ci |
|
It will still need to be rebased |
|
Hi @pirj Sorry, not sure if I got you correctly. "Once the fix s. merged" - This fix needs to be done by me? What is failing? Sorry, this is my first time here :) |
|
Please rebase |
psantos10
force-pushed
the
fix_mailer_generator
branch
from
6830d0b to
c53a51f
Compare
Done. Thanks |
|
Merged, thanks! |
JonRowe
pushed a commit
that referenced
this pull request
Feb 26, 2024
Fix filename produced by the mailer generator.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Rails, I can generate a mailer in both ways:
or
Both ways will create a class
UserMailerunder the fileapp/mailers/user_mailer.rband the test filetest/mailers/user_mailer_test.rb(Minitest).When using RSpec, if I call the command like:
bin/rails generate mailer User, it will create the test file name like:spec/mailers/user_spec.rbinstead ofspec/mailers/user_mailer_spec.rb. The class though, is correct for the mailer test , but no for the preview file.This PR try to solve this