Warn about at_exit hooks being skipped if you force quit. #3054
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pirj
approved these changes
Dec 2, 2023
There was a problem hiding this comment.
Cosmetic: Do we use square brackets in the messages?
Thanks, this makes total sense along with your explanation #3053 (comment)
Quite an odd rspec-expectations failure. I don’t think I’ve seen this before. Wondering if this is caused by a recent with fix.
JonRowe
force-pushed
the
improve-force-quit-message
branch
from
6e7b15c
to
59d5f3a
Compare
JonRowe
added a commit
that referenced
this pull request
Dec 6, 2023
Warn about at_exit hooks being skipped if you force quit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you force quit [issue a double interupt e.g CTRL-C CTRL-C] rspec,
at_exithooks will be skipped through our usage ofexit!(1), this is intended as an emergency get out [and not a "I'm done" with this run] quit as a normal exit finishes running the current spec and runs our hooks for clenaup, there is some confusion about this, so this is an attempt to improve the message.