Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate linter in favor of https://github.com/ykadowak/zerologlint #567

Closed
mitar opened this issue Jul 22, 2023 · 2 comments · Fixed by #574
Closed

Deprecate linter in favor of https://github.com/ykadowak/zerologlint #567

mitar opened this issue Jul 22, 2023 · 2 comments · Fixed by #574

Comments

@mitar
Copy link
Contributor

mitar commented Jul 22, 2023

I think it is confusing to have two linters which are doing the same thing. https://github.com/ykadowak/zerologlint is integrated with go vet or through golangci-lint and it can be run as command line. In general it seems maintained. I think maybe it would be useful to officially endorse it and deprecate this linter to make sure all collective efforts are put into one project.

(I am not affiliated with https://github.com/ykadowak/zerologlint. I just realized that when I run it through golangci-lint I am not using one here.)

@rs
Copy link
Owner

rs commented Aug 2, 2023

I wasn't aware of this. Sounds good, feel free to make a PR and add to the readme that it is now integrated in go vet.

@mitar
Copy link
Contributor Author

mitar commented Aug 2, 2023

I made #574. If I understood you correctly (we are still keeping the lint in the repository, just documenting that it is deprecated).

BTW, I found those tools by chance. They are not mentioned in the main README at all!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants