fix: #841 can't record SVG element inside iframe properly #843
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
el instanceof SVGElement is false if the svg element is inside iframe so that the isSVG property is missing in the recorded data
YunFeng0817
changed the title
|
LGTM, does the diff in the snapshot expected? |
yes, I checked them carefully. The snapshot in the old version is missing the 'isSVG' property |
|
Oh sorry, I forgot to say that the snapshot is changed because I add the integration test for this situation. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is trying to fix issue #841.
SVGElement inside iframe is different from SVGElement outside. So even though an el inside iframe is actually an SVG element
, el instanceof SVGElementis still false and theisSVGproperty is missing in the recorded data.ownerSVGElementeven has better compatibility thanmutation observer.https://caniuse.com/?search=ownerSVGElement
https://caniuse.com/?search=mutationObserver