Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include volume and muted in media elements serialization #796

Closed
wbobeirne opened this issue Jan 12, 2022 · 2 comments
Closed

Include volume and muted in media elements serialization #796

wbobeirne opened this issue Jan 12, 2022 · 2 comments

Comments

@wbobeirne
Copy link

In the same way that currentTime and paused are carried over, it'd be great if volume and muted were too. Muted is especially important due to React not including it in the DOM even when the muted prop is set: facebook/react#10389
Yuyz0112 added a commit that referenced this issue Jan 16, 2022
@Yuyz0112
impl #796 observe media volume change
663c05b
Yuyz0112 added a commit that referenced this issue Jan 16, 2022
@Yuyz0112
impl #796 observe media volume change (#798)
a307c5c
@Yuyz0112
Copy link
Member

Thanks for the feature request, implemented in the latest patch.

@wbobeirne
Copy link
Author

Amazing, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@wbobeirne @Yuyz0112