Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bug where style.opacity was incorrectly deleted when set to zero #765

Merged
merged 1 commit into from
Dec 9, 2021
Merged

Fix bug where style.opacity was incorrectly deleted when set to zero #765

merged 1 commit into from
Dec 9, 2021

Conversation

eoghanmurray
Copy link
Contributor

  • this had the effect of making things visible which should have been invisible
  • not sure what I was thinking with 'potentially non-standard browsers', maybe I thought I was covering return values from getPropertyValue of null or false. Could potentially add explicit tests for null or false, but as there is no evidence for these non-standard browsers, leaving as-is

@eoghanmurray
Fix bug where style.opacity was incorrectly deleted when style.opacit…
810d7a0 
…y was set to zero

 - this had the effect of making things visible which should have been invisible
 - not sure what I was thinking with 'potentially non-standard browsers', maybe I thought I was covering return values from getPropertyValue of null or false. Could potentially add explicit tests for null or false, but as there is no evidence for these non-standard browsers, leaving as-is
@Yuyz0112 Yuyz0112 merged commit ac592dc into rrweb-io:master Dec 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jlalmes jlalmes jlalmes approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@eoghanmurray @jlalmes @Yuyz0112