From ab10d782457fa8396cc8b577d3264f052d496e3e Mon Sep 17 00:00:00 2001 From: Brad Hanks Date: Wed, 3 Jan 2024 18:03:31 -0700 Subject: [PATCH] =?UTF-8?q?refactoring=20opp:=20[F]=20=E2=86=97=20=20is=20?= =?UTF-8?q?more=20efficient=20than?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- lib/credo/check/consistency/space_around_operators.ex | 3 +-- lib/credo/cli/command/diff/diff_summary.ex | 3 +-- lib/credo/cli/output/first_run_hint.ex | 3 +-- lib/credo/cli/output/summary.ex | 3 +-- test/credo/config_file_test.exs | 3 +-- 5 files changed, 5 insertions(+), 10 deletions(-) diff --git a/lib/credo/check/consistency/space_around_operators.ex b/lib/credo/check/consistency/space_around_operators.ex index 169c73605..c2da77eea 100644 --- a/lib/credo/check/consistency/space_around_operators.ex +++ b/lib/credo/check/consistency/space_around_operators.ex @@ -194,8 +194,7 @@ defmodule Credo.Check.Consistency.SpaceAroundOperators do typed_after?, typed_before? ] - |> Enum.filter(& &1) - |> Enum.count() + |> Enum.count(& &1) heuristics_met_count >= 2 end diff --git a/lib/credo/cli/command/diff/diff_summary.ex b/lib/credo/cli/command/diff/diff_summary.ex index 644e15268..a76256346 100644 --- a/lib/credo/cli/command/diff/diff_summary.ex +++ b/lib/credo/cli/command/diff/diff_summary.ex @@ -133,8 +133,7 @@ defmodule Credo.CLI.Command.Diff.DiffSummary do defp category_count(issues, category) do issues - |> Enum.filter(&(&1.category == category)) - |> Enum.count() + |> Enum.count(&(&1.category == category)) end defp summary_parts_new(_source_files, issues) do diff --git a/lib/credo/cli/output/first_run_hint.ex b/lib/credo/cli/output/first_run_hint.ex index d805aa8ab..686b3b0a0 100644 --- a/lib/credo/cli/output/first_run_hint.ex +++ b/lib/credo/cli/output/first_run_hint.ex @@ -24,8 +24,7 @@ defmodule Credo.CLI.Output.FirstRunHint do readability_issue_count = issues - |> Enum.filter(&(&1.category == :readability)) - |> Enum.count() + |> Enum.count(&(&1.category == :readability)) relative_issue_count_per_category = div(issue_count, @category_count) diff --git a/lib/credo/cli/output/summary.ex b/lib/credo/cli/output/summary.ex index 39b85b8ce..dcce0f2cc 100644 --- a/lib/credo/cli/output/summary.ex +++ b/lib/credo/cli/output/summary.ex @@ -120,8 +120,7 @@ defmodule Credo.CLI.Output.Summary do defp category_count(issues, category) do issues - |> Enum.filter(&(&1.category == category)) - |> Enum.count() + |> Enum.count(&(&1.category == category)) end defp summary_parts(source_files, issues) do diff --git a/test/credo/config_file_test.exs b/test/credo/config_file_test.exs index 63c3b090e..62ceada22 100644 --- a/test/credo/config_file_test.exs +++ b/test/credo/config_file_test.exs @@ -457,8 +457,7 @@ defmodule Credo.ConfigFileTest do config_subdir_count = dirs - |> Enum.filter(&String.ends_with?(&1, "config")) - |> Enum.count() + |> Enum.count(&String.ends_with?(&1, "config")) assert config_subdir_count > 1 end