Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: zooming inside a parent dialog that has a close handler #798

Merged
merged 1 commit into from
Dec 29, 2024

Conversation

rpearce
Copy link
Owner

@rpearce rpearce commented Dec 29, 2024

Description

Closes #746

I added all the deps from https://stackblitz.com/edit/vitejs-vite-djxwwz?file=src%2FApp.tsx,package.json and set up a Storybook demo that recreated the issue. I then tried a few things and realized that the zoom component's <dialog>'s close event firing was what was causing the issue with this specific library, so stopping our close event propagation is the fix here.

Verified

This commit was signed with the committer’s verified signature.
rpearce Robert Pearce
@rpearce rpearce added the bug label Dec 29, 2024
@rpearce rpearce self-assigned this Dec 29, 2024
@rpearce rpearce merged commit 11df1ac into main Dec 29, 2024
2 checks passed
@rpearce rpearce deleted the fix/zoom-inside-dialog-with-click-outside-take2 branch December 29, 2024 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

preventDefault for the un-zoom button
1 participant