Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

toml: only highlight inf and nan in value, highlight keys starting with digit #2003

Merged
merged 1 commit into from Mar 18, 2024
Merged

toml: only highlight inf and nan in value, highlight keys starting with digit #2003

merged 1 commit into from Mar 18, 2024

Conversation

arp242
Copy link
Contributor

@arp242 arp242 commented Oct 12, 2023 •
edited

cap-2023-10-12T09:01:03

Fixes #1636
Fixes #1873

@arp242 arp242 changed the title toml: only highlight inf and nan in value toml: only highlight inf and nan in value, highlight keys starting with digit Oct 12, 2023
@arp242
Copy link
Contributor Author

arp242 commented Oct 12, 2023

Actually, I just realized that pushing all the content in the :content group fixes #1636 as well. Doesn't seem to cause any regressions in the test file, so amended this PR.

@tancnle
Copy link
Collaborator

tancnle commented Mar 18, 2024

Thanks, @arp242 ❤️ The changes LGTM 🚀

@tancnle tancnle added this pull request to the merge queue Mar 18, 2024
Merged via the queue into rouge-ruby:master with commit db3f4c7 Mar 18, 2024
7 checks passed
@arp242 arp242 deleted the toml-nan branch March 18, 2024 23:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Toml: inf should not be highlighted in key names TOML: keys starting with digits are not recognized properly
2 participants
@arp242 @tancnle