Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove python3-flake8 workaround for Noble #669

Conversation

christophebedard
Copy link
Member

Follow-up to #658. We needed python3-flake8 version 7.0.0 and had to install it from the noble-proposed apt repo. Now that it is available from the main repo, we can remove this workaround: https://packages.ubuntu.com/noble/python3-flake8

Signed-off-by: Christophe Bedard <christophe.bedard@apex.ai>
@christophebedard christophebedard self-assigned this Apr 15, 2024
@christophebedard christophebedard requested a review from a team as a code owner April 15, 2024 18:45
@christophebedard christophebedard requested review from gbiggs and MichaelOrlov and removed request for a team April 15, 2024 18:45
@christophebedard
Copy link
Member Author

python3-flake8 version 7.0.0 indeed gets installed: https://github.com/ros-tooling/setup-ros/actions/runs/8694433911/job/23843331319?pr=669#step:6:1208

@christophebedard christophebedard merged commit 64b7b57 into master Apr 15, 2024
18 of 19 checks passed
@christophebedard christophebedard deleted the christophebedard/remove-noble-python3-flake8-workaround branch April 15, 2024 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants