Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove EOL ros distros #473

Merged
merged 2 commits into from
Mar 3, 2022
Merged

remove EOL ros distros #473

merged 2 commits into from
Mar 3, 2022

Conversation

ijnek
Copy link
Contributor

@ijnek ijnek commented Mar 3, 2022

Removes EOL ros distros from all scripts. This helps in transitioning to ROS2 Jammy.

Signed-off-by: Kenji Brameld kenjibrameld@gmail.com

@ijnek ijnek requested a review from a team as a code owner March 3, 2022 02:06
@ijnek ijnek requested review from gbiggs and Karsten1987 and removed request for a team March 3, 2022 02:06
@ijnek ijnek mentioned this pull request Mar 3, 2022
@codecov
Copy link

codecov bot commented Mar 3, 2022

Codecov Report

Merging #473 (e9d8bab) into master (c51bc80) will not change coverage.
The diff coverage is n/a.

❗ Current head e9d8bab differs from pull request most recent head 01c6312. Consider uploading reports for the commit 01c6312 to get more accurate results

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #473   +/-   ##
=======================================
  Coverage   93.25%   93.25%           
=======================================
  Files           8        8           
  Lines         163      163           
  Branches       14       14           
=======================================
  Hits          152      152           
  Misses         11       11           
Impacted Files Coverage Δ
src/package_manager/apt.ts 87.50% <ø> (ø)
src/package_manager/pip.ts 100.00% <ø> (ø)
src/setup-ros-linux.ts 100.00% <ø> (ø)
src/setup-ros-windows.ts 78.12% <ø> (ø)
src/utils.ts 95.65% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c51bc80...01c6312. Read the comment docs.

ijnek added 2 commits March 3, 2022 15:21
Signed-off-by: Kenji Brameld <kenjibrameld@gmail.com>
Signed-off-by: Kenji Brameld <kenjibrameld@gmail.com>
@christophebedard
Copy link
Member

Although setup-ros doesn't officially support EOL distros (and the corresponding Ubuntu distros), in the past we've just kept the code around as a best effort kind of thing. Given the various changes needed to support Jammy, I think it's indeed time to drop support for EOL distros. Users can use an older version of setup-ros. I think we might want to bump from v0.2 to v0.3 after this though.

The failing job seems to be unrelated to these changes. Thanks for the PR!

@christophebedard christophebedard merged commit cedd5a2 into ros-tooling:master Mar 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants