Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken with Sphinx 7.3 #106

Closed
tfoote opened this issue Apr 17, 2024 · 5 comments
Closed

Broken with Sphinx 7.3 #106

tfoote opened this issue Apr 17, 2024 · 5 comments
Labels
bug Something isn't working

Comments

@tfoote
Copy link
Member

tfoote commented Apr 17, 2024

Between the CI of #99 and test build on merge the CI appears to have broken

Passing:

https://github.com/ros-infrastructure/rosdoc2/actions/runs/8699265272/job/23857580345

Sphinx==7.2.6

Broken:

https://github.com/ros-infrastructure/rosdoc2/actions/runs/8726584290/job/23942199944

Sphinx==7.3.5

7.3 has come out in the last 2 days with several patch releases:

https://pypi.org/project/Sphinx/#history

image

The core error:

Exception occurred:
  File "/usr/local/lib/python3.10/dist-packages/breathe/directives/function.py", line 161, in DoxygenFunctionDirective
    def _parse_args(self, function_description: str) -> Optional[cpp.ASTParametersQualifiers]:
AttributeError: module 'sphinx.domains.cpp' has no attribute 'ASTParametersQualifiers'
The full traceback has been saved in /tmp/sphinx-err-3wec0qsg.log, if you want to report the issue to the developers.
Please also report this if it was a user error, so that a better error message can be provided next time.
A bug report can be filed in the tracker at <https://github.com/sphinx-doc/sphinx/issues>. Thanks!
@tfoote
Copy link
Member Author

tfoote commented Apr 17, 2024

There's a ticket upstream with a comment saying that Breath is broken too: sphinx-doc/sphinx#12295 (comment)

@tfoote tfoote added the bug Something isn't working label Apr 17, 2024
@tfoote
Copy link
Member Author

tfoote commented Apr 17, 2024

Breath Ticket: breathe-doc/breathe#981

@tfoote
Copy link
Member Author

tfoote commented Apr 17, 2024

Looks like this is patched in main as of an hour ago: sphinx-doc/sphinx#12298 hopefully this will come out shortly. And we can wait a bit for the fix.

@rkent
Copy link
Contributor

rkent commented Apr 17, 2024

Working now with Sphinx 7.3.6 released.

@tfoote
Copy link
Member Author

tfoote commented Apr 17, 2024

Great, I'm retriggering https://github.com/ros-infrastructure/rosdoc2/actions/runs/8726584290 to validate. And it passed!

@tfoote tfoote closed this as completed Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants