-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure reexported namespaces do not prevent creation of default export helpers #5466
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Thank you for your contribution! ❤️You can try out this pull request locally by installing Rollup via npm install rollup/rollup#gh-5465 Notice: Ensure you have installed Rust nightly. If you haven't installed it yet, please first see https://www.rust-lang.org/tools/install to learn how to download Rustup and install Rust, then see https://rust-lang.github.io/rustup/concepts/channels.html to learn how to install Rust nightly. or load it into the REPL: |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5466 +/- ##
==========================================
+ Coverage 98.79% 98.81% +0.02%
==========================================
Files 238 238
Lines 9449 9450 +1
Branches 2407 2407
==========================================
+ Hits 9335 9338 +3
+ Misses 48 47 -1
+ Partials 66 65 -1 ☔ View full report in Codecov by Sentry. |
This PR has been released as part of rollup@4.14.2. You can test it via |
This PR contains:
Are tests included?
Breaking Changes?
List any relevant issue numbers:
Description
The problem here was an asymmetry between the logic deciding if the external namespace needed to be deconflicted locally in
rollup/src/Chunk.ts
Lines 911 to 916 in eebf061
rollup/src/finalisers/shared/getInteropBlock.ts
Line 78 in eebf061