-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: add @shikiji/vitepress-twoslash
#5445
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5445 +/- ##
=======================================
Coverage 98.80% 98.80%
=======================================
Files 236 237 +1
Lines 9423 9432 +9
Branches 2398 2398
=======================================
+ Hits 9310 9319 +9
Misses 48 48
Partials 65 65 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is truly amazing. Makes me wonder if we should start using adding doc comments in the docs, but I would only want to do that if I can then move the entire documentation into the types to avoid the duplicity. Not sure if this is worth it. Just some minor comments for the AMD section, but otherwise I do not see why we cannot merge this, this must have been a ton of work!
Co-authored-by: Lukas Taegert-Atkinson <lukastaegert@users.noreply.github.com>
Yeah, it would be nice to do that. But I haven't found a good way yet. |
This PR has been released as part of rollup@4.14.0. You can test it via |
This PR contains:
Are tests included?
Breaking Changes?
List any relevant issue numbers:
Description
This PR adds
@shikiji/vitepress-twoslash
so that users can hover on the code and see the types.Example with the vite docs: https://elk.zone/m.webtoo.ls/@sapphi_red/112131987169625108
https://rollup-git-fork-sapphi-red-docs-twoslash-rollup-js.vercel.app/plugin-development/#this-load