-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support explicit-resource-management #5444
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Thank you for your contribution! ❤️You can try out this pull request locally by installing Rollup via npm install rollup/rollup#feat/support-using Notice: Ensure you have installed Rust nightly. If you haven't installed it yet, please first see https://www.rust-lang.org/tools/install to learn how to download Rustup and install Rust, then see https://rust-lang.github.io/rustup/concepts/channels.html to learn how to install Rust nightly. or load it into the REPL: |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5444 +/- ##
=======================================
Coverage 98.80% 98.80%
=======================================
Files 237 237
Lines 9432 9435 +3
Branches 2398 2401 +3
=======================================
+ Hits 9319 9322 +3
Misses 48 48
Partials 65 65 ☔ View full report in Codecov by Sentry. |
2fd88f4
to
e13e066
Compare
af6fdb4
to
377e885
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks really good, just one question about the side effect detection.
This PR has been released as part of rollup@4.14.0. You can test it via |
This PR contains:
Are tests included?
Breaking Changes?
List any relevant issue numbers:
resolved #5113
Description
The first version of supporting explicit-resource-management. Currently, using
using
orawait using
keywords always has side effects. In the future, we can add tree-shaking logic for it.The related Estree link: https://github.com/estree/estree/blob/master/stage3/explicit-resource-management.md