Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

systemjs not updated for any string export name spec #5320

Closed
LongTengDao opened this issue Dec 29, 2023 · 2 comments · Fixed by #5321
Closed

systemjs not updated for any string export name spec #5320

LongTengDao opened this issue Dec 29, 2023 · 2 comments · Fixed by #5321

Comments

@LongTengDao
Copy link
Contributor

Rollup Version

4.9.1

Operating System (or Browser)

repl

Node Version (if applicable)

No response

Link To Reproduction

https://rollupjs.org/repl/?version=4.9.1&shareable=JTdCJTIyZXhhbXBsZSUyMiUzQW51bGwlMkMlMjJtb2R1bGVzJTIyJTNBJTVCJTdCJTIyY29kZSUyMiUzQSUyMmV4cG9ydCUyMCU3QiUyMHglMjBhcyUyMCU1QyUyMid4JTVDJTIyJTIwJTdEJTIwZnJvbSUyMCd4JyUzQiU1Q24lNUNuZnVuY3Rpb24lMjBhJTIwKCklMjAlN0IlN0QlNUNuZnVuY3Rpb24lMjBiJTIwKCklMjAlN0IlN0QlNUNuZXhwb3J0JTIwJTdCJTIwYSUyMGFzJTIwJTVDJTIyJ2ElNUMlMjIlMkMlMjBiJTIwYXMlMjAlNUMlMjInYiU1QyUyMiUyMCU3RCUzQiU1Q24lMjIlMkMlMjJpc0VudHJ5JTIyJTNBdHJ1ZSUyQyUyMm5hbWUlMjIlM0ElMjJtYWluLmpzJTIyJTdEJTVEJTJDJTIyb3B0aW9ucyUyMiUzQSU3QiUyMm91dHB1dCUyMiUzQSU3QiUyMmZvcm1hdCUyMiUzQSUyMnN5c3RlbSUyMiU3RCUyQyUyMnRyZWVzaGFrZSUyMiUzQXRydWUlN0QlN0Q=

Expected Behaviour

export { x as "'x" } from 'x';

function a () {}
function b () {}
export { a as "'a", b as "'b" };
System.register(['x'], (function (exports) {
	'use strict';
	return {
		setters: [function (module) {
			exports("'x", module.x);
		}],
		execute: (function () {

			exports({
				"'a": a,
				"'b": b
			});

			function a () {}
			function b () {}

		})
	};
}));

Actual Behaviour

System.register(['x'], (function (exports) {
	'use strict';
	return {
		setters: [function (module) {
			exports(''x', module.x);
		}],
		execute: (function () {

			exports({
				'a: a,
				'b: b
			});

			function a () {}
			function b () {}

		})
	};
}));
@lukastaegert
Copy link
Member

Thanks for spotting, fix at #5321

Copy link

This issue has been resolved via #5321 as part of rollup@4.9.2. You can test it via npm install rollup.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants