Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to redeclare parameters multiple times in nested scopes #5276

Merged
merged 1 commit into from Nov 30, 2023

Conversation

lukastaegert
Copy link
Member

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

List any relevant issue numbers:

Description

When a parameter is redeclared as a var several times in the same nested scope (or in several child scopes of the same nested scope), then this caused a conflict due to some aspects of the var-conflict detection logic. This is fixed here by adding an exception when a var redeclares a parameter.

Copy link

vercel bot commented Nov 29, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
rollup ✅ Ready (Inspect) Visit Preview Nov 29, 2023 7:57pm

Copy link

github-actions bot commented Nov 29, 2023

Thank you for your contribution! ❤️

You can try out this pull request locally by installing Rollup via

npm install rollup/rollup#gh-5274_redeclare_parameter_var

Notice: Ensure you have installed Rust nightly. If you haven't installed it yet, please first see https://www.rust-lang.org/tools/install to learn how to download Rustup and install Rust, then see https://rust-lang.github.io/rustup/concepts/channels.html to learn how to install Rust nightly.

or load it into the REPL:
https://rollup-kqddmrjec-rollup-js.vercel.app/repl/?pr=5276

Copy link

codecov bot commented Nov 29, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b3132dd) 98.86% compared to head (944486a) 98.86%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5276   +/-   ##
=======================================
  Coverage   98.86%   98.86%           
=======================================
  Files         232      232           
  Lines        8952     8953    +1     
  Branches     2335     2336    +1     
=======================================
+ Hits         8850     8851    +1     
  Misses         43       43           
  Partials       59       59           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lukastaegert lukastaegert merged commit 0bf5199 into master Nov 30, 2023
27 checks passed
@lukastaegert lukastaegert deleted the gh-5274_redeclare_parameter_var branch November 30, 2023 05:10
Copy link

This PR has been released as part of rollup@4.6.1. You can test it via npm install rollup.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issue with rollup 4.6.0, building with jspreadsheet
1 participant