Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix mermaid graphs in docs #5272

Merged
merged 2 commits into from
Nov 26, 2023
Merged

Fix mermaid graphs in docs #5272

merged 2 commits into from
Nov 26, 2023

Conversation

lukastaegert
Copy link
Member

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

List any relevant issue numbers:

Description

For some reasons, the deployed graphs on Vercel have broken styles because of wrong ids

Copy link

vercel bot commented Nov 26, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
rollup ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 26, 2023 11:46am

Copy link

github-actions bot commented Nov 26, 2023

Thank you for your contribution! ❤️

You can try out this pull request locally by installing Rollup via

npm install rollup/rollup#debug-svgs

Notice: Ensure you have installed Rust nightly. If you haven't installed it yet, please first see https://www.rust-lang.org/tools/install to learn how to download Rustup and install Rust, then see https://rust-lang.github.io/rustup/concepts/channels.html to learn how to install Rust nightly.

or load it into the REPL:
https://rollup-27hfdrva9-rollup-js.vercel.app/repl/?pr=5272

Copy link

codecov bot commented Nov 26, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (465ae03) 98.86% compared to head (b9b0e3f) 98.86%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5272   +/-   ##
=======================================
  Coverage   98.86%   98.86%           
=======================================
  Files         232      232           
  Lines        8950     8950           
  Branches     2334     2334           
=======================================
  Hits         8848     8848           
  Misses         43       43           
  Partials       59       59           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lukastaegert lukastaegert marked this pull request as ready for review November 26, 2023 12:08
@lukastaegert lukastaegert changed the title Debug deployed graphs Fix mermaid graphs in docs Nov 26, 2023
@lukastaegert lukastaegert merged commit bdb03d0 into master Nov 26, 2023
27 checks passed
@lukastaegert lukastaegert deleted the debug-svgs branch November 26, 2023 12:08
Copy link

This PR has been released as part of rollup@4.6.0. You can test it via npm install rollup.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant