Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: improve the docs repl appearance in the light mode #5145

Merged
merged 1 commit into from Sep 21, 2023

Conversation

TrickyPi
Copy link
Member

@TrickyPi TrickyPi commented Sep 20, 2023

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

List any relevant issue numbers:

Description

After changes
p1
p2

But these changes also slightly affected the dark mode.

@vercel
Copy link

vercel bot commented Sep 20, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
rollup ✅ Ready (Inspect) Visit Preview Sep 20, 2023 3:18am

@github-actions
Copy link

github-actions bot commented Sep 20, 2023

Thank you for your contribution! ❤️

You can try out this pull request locally by installing Rollup via

npm install rollup/rollup#xiaopi-docs-look

Notice: Ensure you have installed Rust nightly. If you haven't installed it yet, please first see https://www.rust-lang.org/tools/install to learn how to download Rustup and install Rust, then see https://rust-lang.github.io/rustup/concepts/channels.html to learn how to install Rust nightly.

or load it into the REPL:
https://rollup-fmlr5dj6e-rollup-js.vercel.app/repl/?pr=5145

@codecov
Copy link

codecov bot commented Sep 20, 2023

Codecov Report

Merging #5145 (33d02a6) into master (5950fc8) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #5145   +/-   ##
=======================================
  Coverage   98.93%   98.93%           
=======================================
  Files         226      226           
  Lines        8444     8444           
  Branches     2319     2319           
=======================================
  Hits         8354     8354           
  Misses         32       32           
  Partials       58       58           

@TrickyPi TrickyPi changed the title Improve the docs repl appearance in the light mode docs: improve the docs repl appearance in the light mode Sep 20, 2023
Copy link
Member

@lukastaegert lukastaegert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, thanks. I can only suspect these changes crept in via updates in vitepress that I overlooked. Thank you for fixing!

@lukastaegert lukastaegert added this pull request to the merge queue Sep 21, 2023
Merged via the queue into master with commit 1e8355b Sep 21, 2023
12 checks passed
@lukastaegert lukastaegert deleted the xiaopi-docs-look branch September 21, 2023 05:05
@rollup-bot
Copy link
Collaborator

This PR has been released as part of rollup@3.29.3. You can test it via npm install rollup.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants