fix: access document.currentScript at the top level #5118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Thank you for your contribution! ❤️You can try out this pull request locally by installing Rollup via npm install rollup/rollup#fix/access-document-current-scriptor load it into the REPL: |
TrickyPi
force-pushed
the
fix/access-document-current-script
branch
from
12a7161
to
8c10d5b
Compare
TrickyPi
force-pushed
the
fix/access-document-current-script
branch
from
8c10d5b
to
c1bbe1c
Compare
Codecov Report
@@ Coverage Diff @@
## master #5118 +/- ##
=======================================
Coverage 98.94% 98.94%
=======================================
Files 226 226
Lines 8429 8442 +13
Branches 2314 2318 +4
=======================================
+ Hits 8340 8353 +13
Misses 32 32
Partials 57 57
|
lukastaegert
reviewed
Sep 5, 2023
lukastaegert
approved these changes
Sep 10, 2023
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
|
This PR has been released as part of rollup@3.29.1. You can test it via |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains:
Are tests included?
Breaking Changes?
List any relevant issue numbers:
Description
Add a new helper
_documentCurrentScriptfor accessing document.currentScirpt at the top level.