-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
perf(sourcemaps): add back lazy sourcemap decode and handling nullish mappings #5087
perf(sourcemaps): add back lazy sourcemap decode and handling nullish mappings #5087
Conversation
Adding back the improvements from rollup#5075
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov Report
@@ Coverage Diff @@
## master #5087 +/- ##
==========================================
- Coverage 98.97% 98.96% -0.01%
==========================================
Files 226 226
Lines 8362 8390 +28
Branches 2294 2303 +9
==========================================
+ Hits 8276 8303 +27
Misses 31 31
- Partials 55 56 +1
|
a32fc7e
to
be5f635
Compare
@lukastaegert Sorry to ping you, but can this be merged and re-released if the change looks good? Bug fix is in the second commit to make it clearer what the problem was, but feel free to squash and merge if you'd like. |
Ah sorry, thanks for reminding me, I will take care. |
This PR has been released as part of rollup@3.28.0. You can test it via |
This PR contains:
Are tests included?
Breaking Changes?
List any relevant issue numbers:
resolves #5084
Description
We weren't properly handling ill-formed (according to types) sourcemap input such as
{mappings: null}
{mappings: undefined}
or{}
. This PR expands the set of values that can be passed in todecodedSourcemaps
to ensure that we are handling all those edge cases and doing something sane. In this case, we treatmappings: null
the same asmappings: ''
and return the "empty sourcemap"