Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(tutorial): change the .js extension to .mjs #5071

Merged
merged 1 commit into from
Jul 23, 2023

Conversation

TrickyPi
Copy link
Member

@TrickyPi TrickyPi commented Jul 22, 2023

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

List any relevant issue numbers:

resolves #5060

Description

Currently, If users study Rollup with the tutorial docs, they will encounter an error that described in issue #5060. This PR changes .js extension of the config file to .mjs, It can fix this issue.

@vercel
Copy link

vercel bot commented Jul 22, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
rollup ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 22, 2023 3:23pm

@codecov
Copy link

codecov bot commented Jul 22, 2023

Codecov Report

Merging #5071 (35f0c8d) into master (766da86) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #5071   +/-   ##
=======================================
  Coverage   98.97%   98.97%           
=======================================
  Files         226      226           
  Lines        8357     8357           
  Branches     2293     2293           
=======================================
  Hits         8271     8271           
  Misses         31       31           
  Partials       55       55           

Copy link
Member

@lukastaegert lukastaegert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for taking care!

@lukastaegert lukastaegert added this pull request to the merge queue Jul 23, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jul 23, 2023
@lukastaegert lukastaegert added this pull request to the merge queue Jul 23, 2023
Merged via the queue into rollup:master with commit 2e8b2e9 Jul 23, 2023
12 checks passed
@TrickyPi TrickyPi deleted the docs-5060 branch July 24, 2023 08:53
@rollup-bot
Copy link
Collaborator

This PR has been released as part of rollup@3.27.0. You can test it via npm install rollup.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Node tried to load your configuration file as CommonJS even though it is likely an ES module.
3 participants