Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: __NO_SIDE_EFFECTS__ annotation for async function #5031

Merged
merged 3 commits into from Jun 12, 2023

Conversation

antfu
Copy link
Contributor

@antfu antfu commented Jun 11, 2023

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

List any relevant issue numbers:

Description

Thanks to @evanw for his finding: evanw/esbuild#3149 (comment). I missed async functions and generators in the initial PR. I think __NO_SIDE_EFFECTS__ should take higher priority than super.hasEffectsOnInteractionAtPath.

@vercel
Copy link

vercel bot commented Jun 11, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
rollup ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 11, 2023 9:52pm

@codecov
Copy link

codecov bot commented Jun 11, 2023

Codecov Report

Merging #5031 (5274c69) into master (de2d6ff) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #5031   +/-   ##
=======================================
  Coverage   98.96%   98.96%           
=======================================
  Files         222      222           
  Lines        8210     8213    +3     
  Branches     2258     2259    +1     
=======================================
+ Hits         8125     8128    +3     
  Misses         30       30           
  Partials       55       55           
Impacted Files Coverage Δ
src/ast/nodes/ArrowFunctionExpression.ts 95.45% <100.00%> (+0.21%) ⬆️
src/ast/nodes/shared/FunctionBase.ts 98.36% <100.00%> (+0.05%) ⬆️

@lukastaegert lukastaegert added this pull request to the merge queue Jun 12, 2023
Merged via the queue into rollup:master with commit b1341bf Jun 12, 2023
12 checks passed
@rollup-bot
Copy link
Collaborator

This PR has been released as part of rollup@3.25.1. You can test it via npm install rollup.

@antfu antfu deleted the fix/no-side-effect-async branch June 12, 2023 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants