Provide synthetic namespace for dynamic imports when perserving modules #4913
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9 tasks
Thank you for your contribution! ❤️You can try out this pull request locally by installing Rollup via npm install rollup/rollup#gh-4905-dynamic-import-syntheticor load it into the REPL: |
Codecov Report
@@ Coverage Diff @@
## master #4913 +/- ##
==========================================
- Coverage 99.01% 99.01% -0.01%
==========================================
Files 221 221
Lines 8030 8029 -1
Branches 2211 2210 -1
==========================================
- Hits 7951 7950 -1
Misses 26 26
Partials 53 53
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
This PR has been released as part of rollup@3.20.0. You can test it via |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains:
Are tests included?
Breaking Changes?
List any relevant issue numbers:
preserveModules: trueandpreserveEntrySignatures: 'allow-extension'when module has no export name #4905Description
When dynamically importing a module with a synthetic namespace, we always need a pre-created dynamic namespace object. This was conflicting with the logic to prevent such objects when preserving modules.
The solution here is to still create these objects for this exact scenario, even if it means adding an additional export to the module.