Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(replace): clarify options for allowed replacement values #422

Merged
merged 1 commit into from
Jun 1, 2020
Merged

docs(replace): clarify options for allowed replacement values #422

merged 1 commit into from
Jun 1, 2020

Conversation

stephane-vanraes
Copy link
Contributor

Rollup Plugin Name: replace

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

If yes, then include "BREAKING CHANGES:" in the first commit message body, followed by a description of what is breaking.

List any relevant issue numbers:

#399

Description

This PR updates the documentation as stated in #399 to clarify that functions can be used as replacement options using the replace plugin. Testing revealed that replacing with numbers also works, so I changed the wording strings into primitives (unsure if that's a good term ?)

Sorry, something went wrong.

Copy link
Collaborator

@shellscape shellscape left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@shellscape shellscape changed the title [docs] Clarify options on replace plugin docs(replace): clarify options for allowed replacement values Jun 1, 2020
@shellscape shellscape merged commit 6446657 into rollup:master Jun 1, 2020
LarsDenBakker pushed a commit to LarsDenBakker/plugins that referenced this pull request Sep 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants