Upgrade V8 binaries for 10.9.194.9 version **working**

[jacques-n]

Use existing workflows to build latest V8 artifacts as well as code changes to ensure v8go continues to work.

Includes:

• Update github workflow to use go 1.8 & 1.9
• Update github workflow to use macos-latest
• Update github build workflow to use ubuntu 22.04
• Add gitignore for jetbrains and .gclient_previous files
• Switch cgo build to C++17 and enable sandbox at build time
• Update test with update to date error message
• Remove no longer supported build flag.
• Move initialization to v8go.go and include flag set to avoid flag freezing
• Reorder initialization so allocator is initialized after v8 (required by latest v8)
• Commits are kept separate with merges to certify provenance of all library objects built using existing rogchap/v8go mechanisms.

This is reopen of the previous PR using a different branch name so github action automation doesn't accidentally close or overwrite.

[jacques-n]

@fizx, can you review this? It's basically trivial changes other than the v8 upgrade.

[codecov]

Codecov Report

Base: 95.28% // Head: 95.31% // Increases project coverage by +0.03% 🎉

Coverage data is based on head (ab039ba) compared to base (7d843f1).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #363      +/-   ##
==========================================
+ Coverage   95.28%   95.31%   +0.03%     
==========================================
  Files          17       17              
  Lines         594      598       +4     
==========================================
+ Hits          566      570       +4     
  Misses         19       19              
  Partials        9        9              

Impacted Files	Coverage Δ
isolate.go	100.00% <100.00%> (ø)
v8go.go	100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

[RGood]

Changes look great, thanks for the repo maintenance.

Would like an additional reviewer but you have a 👍 from me

[RGood]

Last ask I have would be to update the CHANGELOG.md

[dylanahsmith]

https://github.com/rogchap/v8go#v8-dependency says

Due to security concerns of binary blobs hiding malicious code, the V8 binary is built via CI ONLY.

Could you instead open a PR against the #357 branch with the changes needed to fix the build, but without committing the actual V8 build. I can then merge this PR into that branch and trigger the V8 Build workflow (as documented in https://github.com/rogchap/v8go#upgrading-the-v8-binaries) to merge in the V8 binaries.

[dylanahsmith]

This comment is no longer relevant

Suggested change

	# We use macos-11 over macos-latest because macos-latest defaults to Catalina(10.15) and not Big Sur(11.0)
	# We can switch to macos-latest whenever Big Sur becomes the default
	# See https://github.com/actions/virtual-environments#available-environments

[jacques-n]

https://github.com/rogchap/v8go#v8-dependency says

Due to security concerns of binary blobs hiding malicious code, the V8 binary is built via CI ONLY.

Could you instead open a PR against the #357 branch with the changes needed to fix the build, but without committing the actual V8 build. I can then merge this PR into that branch and trigger the V8 Build workflow (as documented in https://github.com/rogchap/v8go#upgrading-the-v8-binaries) to merge in the V8 binaries.

Can do.

FYI: this patch already followed that pattern to address this concern: the v8 build commits within this patch are were generated by Github action CI and are maintained as separate commits to guarantee hash provenance. (You'll need to look at the individual commits of this PR to actually see this-- each is a GH generated PR with merge commit to guarantee hash history)

[dylanahsmith]

Sorry, my mistake about thinking the build wasn't CI generated. Github Actions seems to now attribute the automated commits to a person (e.g. 208b63e is attributed to me) which made it look like a local build.

misunderstanding of build providence

[jacques-n]

Sorry, my mistake about thinking the build wasn't CI generated. Github Actions seems to now attribute the automated commits to a person (e.g. 208b63e is attributed to me) which made it look like a local build.

I've kept as is.

If you'd like, I can back out the v8 builds but then someone else just has to do them again :D

I've updated the changelog. Let me know if you are happy with this.

[dylanahsmith]

This branch is out-of-date with the base branch

Looks like the branch protection requires branches to be up to date before merging. I also don't have permission to push a merge of master into this branch to fix it myself for merging. @jacques-n could you get this branch up-to-date so it can be merged?

[jacques-n]

Updated