Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Any instructions for m1 builds #171

Closed
fizx opened this issue Sep 10, 2021 · 5 comments · Fixed by #202
Closed

Any instructions for m1 builds #171

fizx opened this issue Sep 10, 2021 · 5 comments · Fixed by #202

Comments

@fizx
Copy link
Collaborator

fizx commented Sep 10, 2021

I know that we're not ready to prebuild on github actions, but it would be wonderful to be able to do locally

Thanks :)

@dylanahsmith
Copy link
Collaborator

I know that we're not ready to prebuild on github actions

You mean it Github Actions isn't ready for Apple M1 , since it sounds like it doesn't have support for it yet: actions/runner-images#2187

In the meantime, you can try doing the following locally to see if v8 will build:

  1. Checkout the v8go repo
  2. Clone the submodules git submodule update --init --recursive
  3. Build the v8 binary for your OS and architecture deps/build.py

If that works, then you can try modifying cgo.go and add a deps/*/vendor.go file so the built libv8.a can be used.

@colinking
Copy link
Contributor

We also needed M1 support and were able to get it building locally using the instructions in the README: https://github.com/airplanedev/v8go/pull/5

@fizx
Copy link
Collaborator Author

fizx commented Sep 20, 2021

@colinking Nice!

I couldn't get v8 to build correctly, but I was able to link the dynamic library from homebrew's v8.

@natemoo-re
Copy link

@colinking I was able to run the airplanedev fork on my M1—great work! 🎉

@epk
Copy link
Contributor

epk commented Oct 24, 2021

Added M1 support in #202, however I do not have access to a machine with Apple Silicon to test this out.

I wish I looked at this issue and @colinking's PR before going down this rabbit hole on a weekend 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants