Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix definition_methods with implements #4670

Merged
merged 2 commits into from
Oct 17, 2023
Merged

Conversation

rmosolgo
Copy link
Owner

Previously, the DefinitionMethods module was added (via extend) right away, and later inclusions would take priority over it. Now, that module is added as late as possible, so it will override any previously-added methods.

Fixes #4657

Another approach would be to use prepend on the singleton class. We can look into it if this lazy-extend approach doesn't work.

Verified

This commit was signed with the committer’s verified signature.
jbedard Jason Bedard
@rmosolgo rmosolgo added this to the 2.1.4 milestone Oct 17, 2023
@rmosolgo rmosolgo merged commit 2e26791 into master Oct 17, 2023
@rmosolgo rmosolgo deleted the inmplements-definition-methods branch February 20, 2025 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

resolve_type does not get called on nested interface types
1 participant