Fix definition_methods with implements #4670
Merged
+69
−10
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the
DefinitionMethods
module was added (viaextend
) right away, and later inclusions would take priority over it. Now, that module is added as late as possible, so it will override any previously-added methods.Fixes #4657
Another approach would be to use
prepend
on the singleton class. We can look into it if this lazy-extend
approach doesn't work.