feature: reimplement #2473 by implementing a TimeWidget in core #3510
+1,144
−140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added a new `TimeWidget` that supports entering in times as HH:mm AM/PM - In `@rjsf/utils`, added a `time` to `TimeWidget` mapping for `string` in `getWidgets.ts` - In `@rjsf/core`, reimplemented the `TimeWidget` based on rjsf-team#2473 - Updated the tests to verify the new `TimeWidget` works appropriately - In all the themes, updated the tests to verify the rendering of the time widget - In `@rjsf/material-ui` and `@rjsf/mui` added `time` to the shrink list in `BaseInputTemplate` - Updated the documentation for the new `TimeWidget` support - Also verified that the latest Firefox browsers support the native components - Updated the `CHANGELOG.md` accordingly
nickgros
approved these changes
Mar 16, 2023
Co-authored-by: Nick Grosenbacher <nickgrosenbacher@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reasons for making this change
Added a new
TimeWidgetthat supports entering in times as HH:mm AM/PM@rjsf/utils, added atimetoTimeWidgetmapping forstringingetWidgets.ts@rjsf/core, reimplemented theTimeWidgetbased on Add TimeWidget #2473TimeWidgetworks appropriately@rjsf/material-uiand@rjsf/muiaddedtimeto the shrink list inBaseInputTemplateTimeWidgetsupportCHANGELOG.mdaccordinglyChecklist
npm run test:updateto update snapshots, if needed.