Update docs to check for empty object #100
Merged
+2
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi! I recently came across this project. Huge fan.
One issue that I ran into was checking if no files had been uploaded. The docs recommend
if (!req.files)
. But asreq.files
has been intentionally left as an empty object to follow the same conventions of other middlewares, this if statement will never be true. The reasonable way seems to be to check if the object is empty. I've updated the docs to reflect this.There's also some discussion about this in #31
Thanks : )