- Sponsor
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
AddUrlSegment accepts object values but internally casts to strings causing exception #1682
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
It would also be nice if you actually follow the contribution guidelines and provide stack trace and exception details. But, I see what happens. Will try to fix it tomorrow. |
First of all thanks for the quick fix!
Sorry about that. I thought pointing out the source of the issue and why it was an issue was descriptive enough. Will keep that in mind for next time. |
You're right. I got it right after looking into the links you provided. I usually scan the issue content, and when it has no stack trace, it looks incomplete to me :) |
Btw I made constructors for all parameter types (except the abstract one) more explicit. The old Also, |
It will break some existing code of course... I understand that you got this error when passing something like a number or a boolean. Not sure how to fix it better. Maybe I need to return the overload that accepts |
This change 8e96bba#diff-5df1c2c9f9f84319d21c361a0a336251f7698927e2f1c0b0adab575fa407c6e6 simply casts object values into strings, this is causing issues since the public api accepts object values.
The text was updated successfully, but these errors were encountered: