typo:Log the worker name when starting the task #1837
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
in resque@7d0b20e the code was refactored to move the startup of workers into the worker class. As part of this, most of the references were changed from 'worker' to 'self'. This also happened to the line logging worker startup, but that line did not move into the worker, so now it just logs "Starting worker main", taking the name main from `rake`. You can still see the old behaviour in the documentation: https://github.com/resque/resque/blob/7f6b88404dd18698f6f4023e18fdc1ae8318e5e5/examples/demo/README.markdown#L29 There was no explanation for this change so it just looks like a typo to me? It came up for us reading logs and trying to understand where the 'Starting worker main' came from, since it didn't match up to the workers we had crashing.
PatrickTulskie
approved these changes
Dec 28, 2022
|
@bazzargh hey yeah this looks like a good fix to me. Mind rebasing so we can get specs to run with the latest changes and we can tee it up for the next release. |
PatrickTulskie
approved these changes
Jan 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in 7d0b20e the code was refactored to move the startup of workers into the worker class. As part of this, most of the references were changed from 'worker' to 'self'. This also happened to the line logging worker startup, but that line did not move into the worker, so now it just logs "Starting worker main", taking the name main from
rake. You can still see the old behaviour in the documentation:resque/examples/demo/README.markdown
Line 29 in 7f6b884
There was no explanation for this change so it just looks like a typo to me? It came up for us reading logs and trying to understand where the 'Starting worker main' came from, since it didn't match up to the workers we had crashing.