Update redis test matrix for 5.0 #1824
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nevans
reviewed
Aug 29, 2022
| @@ -20,6 +20,8 @@ jobs: | |||
| - 4.4 | |||
| - 4.5 | |||
| - 4.6 | |||
| - 4.7 | |||
| - 4.8 | |||
There was a problem hiding this comment.
Also need some new exclusions:
exclude:
- { ruby-version: 2.3, redis-version: 4.5 } # already excluded
- { ruby-version: 2.3, redis-version: 4.6 } # already excluded
- { ruby-version: 2.3, redis-version: 4.7 }
- { ruby-version: 2.3, redis-version: 4.8 }
- { ruby-version: 2.3, redis-version: latest } # already excluded
- { ruby-version: 2.4, redis-version: latest }There was a problem hiding this comment.
Thanks. Will get that hammered out soon.
|
@iloveitaly @nevans if you hit me with the 👍 I'll merge this in and use it to make sure that #1822 gets us back to green and nothing else looks funky after that's merged in... then I'll prep a patch release. |
iloveitaly
approved these changes
Aug 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Need to get CI running against latest redis-rb versions.