Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@reservoir0x/reservoir-sdk depends on vulnerable versions of axios #568

Closed
FrancoAguzzi opened this issue Feb 5, 2024 · 4 comments
Closed

Comments

@FrancoAguzzi
Copy link

After running npm audit in my project, the following vulnerability was raised:

Captura de Tela 2024-02-05 às 18 15 48

I am using these lib's version:

  "@reservoir0x/reservoir-kit-ui": "1.22.0",
  "@reservoir0x/reservoir-sdk": "1.12.3",

Does the team have any plan on acting on this so lib's source code does not rely on a vulnerable external lib version?

@pedromcunha
Copy link
Member

pedromcunha commented Feb 6, 2024

Hi, did this get patched in axios yet? Once it is we'll upgrade axios to the version that has the patch.

Edit:
Looks like we're on a pretty old version of axios, going to upgrade this to fix any security vulnerabilities that have already been patched by axios. Should have something within a few days. Thank you for bringing this up.

@FrancoAguzzi
Copy link
Author

Hi @pedromcunha, I assume so! axios/axios#6022 (comment)

And I feel happy that this collaborated with your tech evolution, yw 😃👍🏼

@pedromcunha
Copy link
Member

Alright, the patch is out in the latest release, let me know if you run into any issues and happy coding!

@FrancoAguzzi
Copy link
Author

Audit is not anymore triggering warnings and application's build ran perfectly. Thanks a lot, @pedromcunha 😊🙏🏼

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants