Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support MSBuild SDK via Sdk attribute on Project #29101

Open
rarkins opened this issue May 15, 2024 Discussed in #29048 · 4 comments · May be fixed by #29330
Open

Support MSBuild SDK via Sdk attribute on Project #29101

rarkins opened this issue May 15, 2024 Discussed in #29048 · 4 comments · May be fixed by #29330
Labels
manager:nuget NuGeT (.NET) package manager priority-3-medium Default priority, "should be done" but isn't prioritised ahead of others type:feature Feature (new functionality)

Comments

@rarkins
Copy link
Collaborator

rarkins commented May 15, 2024

Discussed in #29048

Originally posted by ForNeVeR May 14, 2024

Tell us more.

In MSBuild, it's possible to specify the SDK like this:

<Project Sdk="Microsoft.Build.NoTargets/3.4.0">
</Project>

Currently, Renovate supports specifying of these versions via global.json, but not via the project files themselves.

See the documentation (look for the Sdk attribute description).

@rarkins rarkins added type:feature Feature (new functionality) priority-3-medium Default priority, "should be done" but isn't prioritised ahead of others manager:nuget NuGeT (.NET) package manager labels May 15, 2024
@ForNeVeR
Copy link

Entry point for implementation would be manager/nuget/extract.ts, I believe.

@RahulGautamSingh
Copy link
Collaborator

RahulGautamSingh commented May 29, 2024

It is also possible to specify sdkname & version in a <Sdk> element.1
Should I do add that in the same PR or create a new issue for it?

Footnotes

  1. (https://learn.microsoft.com/en-us/visualstudio/msbuild/sdk-element-msbuild?view=vs-2022)

@ForNeVeR
Copy link

I think it would be ok to have both in same PR. These are very related features.

@RahulGautamSingh
Copy link
Collaborator

There is also a third way to add project sdks using the Import element

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
manager:nuget NuGeT (.NET) package manager priority-3-medium Default priority, "should be done" but isn't prioritised ahead of others type:feature Feature (new functionality)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants