Skip to content

Include , to index.d.ts #871

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Jasonnnz opened this issue Mar 17, 2023 · 7 comments · Fixed by #879 or #880 · May be fixed by X-oss-byte/gatsby-1#782, X-oss-byte/gatsby-1#795 or X-oss-byte/gatsby-1#825
Closed

Include , to index.d.ts #871

Jasonnnz opened this issue Mar 17, 2023 · 7 comments · Fixed by #879 or #880 · May be fixed by X-oss-byte/gatsby-1#782, X-oss-byte/gatsby-1#795 or X-oss-byte/gatsby-1#825
Assignees
Labels
bug Something isn't working

Comments

@Jasonnnz
Copy link

Problem

Currently the index.d.ts file does not have a , at the end of line 10.

Suggested Solution

Add , to the end of line 10

Keywords

TS, TypeScript

@Jasonnnz Jasonnnz added the feature New feature or request label Mar 17, 2023
@remarkablemark
Copy link
Owner

remarkablemark commented Mar 17, 2023

Question: what does adding the , do for this library? Does not having the trailing comma cause issues for you?

@Jasonnnz
Copy link
Author

Thanks for the quick reply!

I guess it'd just help avoid a TS Error - ',' expected.ts(1005). My builds failing due to this minor thing.

@remarkablemark
Copy link
Owner

remarkablemark commented Mar 17, 2023

Hmm interesting. I find it strange that TypeScript would fail on that line: https://github.com/remarkablemark/html-react-parser/blob/v3.0.12/index.d.ts#L10

I haven't experienced your issue before. What TypeScript version are you using? Possible to create a reproducible example?

@remarkablemark remarkablemark added question Further information is requested and removed feature New feature or request labels Mar 17, 2023
@stilldesign
Copy link

stilldesign commented Mar 24, 2023

I too am encounting this issue -
I tried:

  • Upgrading to typescript 5.0.2
  • Upgrading my @typescript-eslint to the latest
  • I'm using node 16 (and tried 18)
  • Using yarn

image

@remarkablemark remarkablemark added bug Something isn't working and removed question Further information is requested labels Mar 24, 2023
@remarkablemark
Copy link
Owner

@stilldesign
Copy link

I updated to the new package and it has solved the issue, thank you so much for the quick fix and the cool project 🙂

@remarkablemark
Copy link
Owner

@stilldesign Thanks for confirming!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment