fix(attributes-to-props): don't convert value of option tag

[adammockor]

What is the motivation for this pull request?

Fixes #625 and closes ##628. Not sure if there is another element affected with this issue then option.

What is the current behavior?

attributesToProps converts value attribute to defaultValue of option element what is not desirable.

What is the new behavior?

value attribute is preserved on option element.

Checklist:

• Conventional Commits
• Tests
• Documentation
• Types

[remarkablemark]

Looks good overall, left some comments

[remarkablemark]

@adammockor You'll also need to update .size-limit.json since it has increased:

npm run size-limit

[adammockor]

Thank you for review.

About the API, I am not sure how to approach it. I made second parameter nodeName optional - so it's no breaking change, but this way it's not obvious why nodeName should be passed. Could be better to pass just node into the function (and rename it to nodeAttributesToProps). You could consider it for next major release.

[remarkablemark]

Thanks for addressing my previous comments. I've left 2 more comments.

[remarkablemark]

Thank you for review.

About the API, I am not sure how to approach it. I made second parameter nodeName optional - so it's no breaking change, but this way it's not obvious why nodeName should be passed. Could be better to pass just node into the function (and rename it to nodeAttributesToProps). You could consider it for next major release.

I think the 2nd parameter is fine since it's optional and backwards compatible. Thanks for opening this PR!

[remarkablemark]

LGTM

[codecov-commenter]

Codecov Report

Merging #790 (757e0f7) into master (0062056) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master      #790   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            8         8           
  Lines          171       172    +1     
  Branches        57        58    +1     
=========================================
+ Hits           171       172    +1     

Impacted Files	Coverage Δ
lib/attributes-to-props.js	100.00% <100.00%> (ø)
lib/dom-to-react.js	100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[remarkablemark]

Release:

• chore(master): release 3.0.7 #791 (comment)